From 0b9bad68a15632bfe4d41c829048fccd0589d601 Mon Sep 17 00:00:00 2001 From: David Geary Date: Fri, 16 Aug 2024 19:32:03 +0100 Subject: [PATCH] Remove creation of redundant tag from 'create release' workflow --- .github/workflows/create-release.yml | 4 +--- BUILD.md | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml index 675dcf6..ef2609e 100644 --- a/.github/workflows/create-release.yml +++ b/.github/workflows/create-release.yml @@ -77,7 +77,7 @@ jobs: commit_user_name: ${{ github.actor }} commit_user_email: ${{ github.actor }}@users.noreply.github.com - - name: Update git tag on latest commit + - name: Remove original git tag # The deletes the original prefixed tag on the remote (origin) repo but # obviously doesn't remove it from any local repos that created/pulled # the tag beforehand. That shouldn't be an issue though, as we're only @@ -85,8 +85,6 @@ jobs: run: | git tag -d ${{ steps.get-tag.outputs.tag }} git push origin :refs/tags/${{ steps.get-tag.outputs.tag }} - git tag v${{ steps.get-version.outputs.version }} - git push origin --tags - name: Create draft Github pre-release for ${{ steps.get-version.outputs.version }} (${{ env.IS_PRERELEASE }}) if: env.IS_PRERELEASE == 'true' diff --git a/BUILD.md b/BUILD.md index f3ffbdf..0099fb4 100644 --- a/BUILD.md +++ b/BUILD.md @@ -24,8 +24,8 @@ In creating the release, the "build#" prefix will be removed from the tag and th version number. The workflow will update the `version` properties in the repo's _package.json_ files for both the top-level project and the library, and then these updated files will be committed back to the repo. Because the original 'build#' tag is no longer on the commit that represents the -release, that tag will be deleted and a new tag matching the version number added to the new commit -to correctly identify it as the source of the release. +release, that tag will be deleted (the new release will automatically create a tag matching the +version number on the new commit to correctly identify it as the source of the release). > This does mean that the release author (and anyone pulling the `main` branch after the build tag has been added but before the release has been created) will end up with a redundant tag in their