Change type Model = i32 to struct Model { counter: i32 } in App 1: Counter

[rutrum]

I think using this pattern doesn't make it obvious for how users might expand on the example. If a user does decide to use a struct as their model, the code written in update and view also need to updated, while not always obvious. For example, a user might try to do this:

struct Model {
    name: String,
}
fn view(model: &Model) -> Node<Msg> {
    div![
        button![model],
    ]
}

...and not realize that you can't use model in this way as you could when it was a type alias. I think more modular the first example is the best it is for the user experience.

[MartinKavik]

If I remember correctly, you are not the first one who suggested this change and I think it's a good idea. The type alias was inspired by the Elm Counter / Buttons.

However together with the change in this repo we should update the example and related docs also in:

• https://github.com/seed-rs/seed/blob/master/README.md
• https://github.com/seed-rs/seed/blob/master/src/lib.rs#L1-L47
• https://seed-rs.org/0.7.0/app_1_counter (+ other guides / pages if necessary)
• Is it all?

@rutrum Do you want to update it? I would be very thankful.

[MartinKavik]

Related issue: seed-rs/seed-rs.org#57

[zakaluka]

@MartinKavik The 3 referenced areas have been updated. However, there is (at least) one separate page on the website for the Model that I haven't updated yet. Will take a shot at it shortly.

[MartinKavik]

@zakaluka Good job! It looks like the main Seed README is the last one to change - do you want to update it too?