From 9883151f85d555266e40e69e876f1dec8a632c5a Mon Sep 17 00:00:00 2001 From: Michael Grosse Huelsewiesche Date: Tue, 7 Jan 2025 12:42:21 -0500 Subject: [PATCH] Added missing metric from older analytics packaged (#1189) --- .changeset/spicy-baboons-care.md | 5 +++++ packages/browser/src/browser/__tests__/integration.test.ts | 5 ++++- packages/browser/src/core/analytics/index.ts | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 .changeset/spicy-baboons-care.md diff --git a/.changeset/spicy-baboons-care.md b/.changeset/spicy-baboons-care.md new file mode 100644 index 000000000..95ad631c1 --- /dev/null +++ b/.changeset/spicy-baboons-care.md @@ -0,0 +1,5 @@ +--- +'@segment/analytics-next': patch +--- + +Added missing telemetry metric. diff --git a/packages/browser/src/browser/__tests__/integration.test.ts b/packages/browser/src/browser/__tests__/integration.test.ts index 1254962fc..bfdb46be8 100644 --- a/packages/browser/src/browser/__tests__/integration.test.ts +++ b/packages/browser/src/browser/__tests__/integration.test.ts @@ -650,6 +650,7 @@ describe('Dispatch', () => { expect(metrics.map((m) => m.metric)).toMatchInlineSnapshot(` [ + "analytics_js.invoke", "message_dispatched", "plugin_time", "plugin_time", @@ -694,7 +695,9 @@ describe('Dispatch', () => { }) await sleep(10) - expect(fetchCalls[1].url).toBe('http://new.api.io/m') + expect(fetchCalls.some((call) => call.url === 'http://new.api.io/m')).toBe( + true + ) }) }) diff --git a/packages/browser/src/core/analytics/index.ts b/packages/browser/src/core/analytics/index.ts index 1cdf12e95..e4c57e819 100644 --- a/packages/browser/src/core/analytics/index.ts +++ b/packages/browser/src/core/analytics/index.ts @@ -516,6 +516,7 @@ export class Analytics callback?: Callback ): Promise { const ctx = new Context(event) + ctx.stats.increment('analytics_js.invoke', 1, [event.type]) if (isOffline() && !this.options.retryQueue) { return ctx }