diff --git a/.github/workflows/publish_release.yaml b/.github/workflows/publish_release.yaml
index 2ff27cbe..e0884f3a 100644
--- a/.github/workflows/publish_release.yaml
+++ b/.github/workflows/publish_release.yaml
@@ -6,7 +6,7 @@ name: Publish release
on:
release:
- types: [ published ]
+ types: [ created ]
workflow_dispatch:
jobs:
diff --git a/addons/gst-web/src/app.js b/addons/gst-web/src/app.js
index 57dbdf75..20512ccf 100644
--- a/addons/gst-web/src/app.js
+++ b/addons/gst-web/src/app.js
@@ -237,7 +237,7 @@ var app = new Vue({
},
videoFramerate(newValue) {
if (newValue === null) return;
- console.log("video frame rate changed to " + newValue);
+ console.log("video framerate changed to " + newValue);
webrtc.sendDataChannelMessage('_arg_fps,' + newValue);
this.setIntParam("videoFramerate", newValue);
},
diff --git a/addons/gst-web/src/index.html b/addons/gst-web/src/index.html
index 7bd4f51e..abe42658 100644
--- a/addons/gst-web/src/index.html
+++ b/addons/gst-web/src/index.html
@@ -145,7 +145,7 @@
{{ connectionVideoBitrate }}
- Current video bit rate in mbps vs selected bit rate {{ (videoBitRate / 1000).toFixed(0) }}
+ Current video bitrate in mbps vs selected bitrate {{ (videoBitRate / 1000).toFixed(0) }}
mbps
@@ -264,17 +264,17 @@
-
+
-
+
-
@@ -294,15 +294,15 @@
Video encoder: {{ encoderName }}
Window size: {{ windowResolution[0] }}x{{ windowResolution[1] }}
Video decoder: {{ connectionVideoDecoder }}
- Frame rate: {{ connectionFrameRate }} fps
- Bit rate: {{ connectionVideoBitrate }} mbps
+ Framerate: {{ connectionFrameRate }} fps
+ Bitrate: {{ connectionVideoBitrate }} mbps
Available receive bandwidth: {{ connectionAvailableBandwidth }}
Audio Stats
- Latency: {{ connectionAudioLatency }} ms
- Codec: {{ connectionAudioCodecName }}
- - Bit rate: {{ connectionAudioBitrate }} kbps
+ - Bitrate: {{ connectionAudioBitrate }} kbps
diff --git a/src/selkies_gstreamer/gstwebrtc_app.py b/src/selkies_gstreamer/gstwebrtc_app.py
index 8d6c2525..c0914c9b 100644
--- a/src/selkies_gstreamer/gstwebrtc_app.py
+++ b/src/selkies_gstreamer/gstwebrtc_app.py
@@ -231,7 +231,7 @@ def build_video_pipeline(self):
# Rate control mode tells the encoder how to compress the frames to
# reach the target bitrate. A Constant Bit Rate (CBR) setting is best
- # for streaming use cases as bit rate is the most important factor.
+ # for streaming use cases as bitrate is the most important factor.
# A Variable Bit Rate (VBR) setting tells the encoder to adjust the
# compression level based on scene complexity, something not needed
# when streaming in real-time.
@@ -242,7 +242,7 @@ def build_video_pipeline(self):
# Infinite GOP is best for streaming because it reduces the number
# of large I-Frames being transmitted. At higher resolutions, these
# I-Frames can dominate the bandwidth and add additional latency.
- # With infinite GOP, you can use a higher bit rate to increase quality
+ # With infinite GOP, you can use a higher bitrate to increase quality
# without a linear increase in total bandwidth.
# A negative consequence when using infinite GOP size is that
# when packets are lost, it may take the decoder longer to recover.
@@ -880,10 +880,10 @@ def send_reload_window(self):
"system", {"action": "reload"})
def send_framerate(self, framerate):
- """Sends the current frame rate to the data channel
+ """Sends the current framerate to the data channel
"""
- logger.info("sending frame rate")
+ logger.info("sending framerate")
self.__send_data_channel_message(
"system", {"action": "framerate,"+str(framerate)})