Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change verification key points in contract to constant #330

Closed
saleel opened this issue Jun 1, 2023 · 5 comments · Fixed by #875
Closed

Change verification key points in contract to constant #330

saleel opened this issue Jun 1, 2023 · 5 comments · Fixed by #875
Assignees
@jimmychu0807
Labels
feature 🚀 This is enhancing something existing or creating something new good first issue Good for newcomers hacktoberfest Encourages contributions to open source during Hacktoberfest.

Comments

@saleel
Copy link
Contributor

saleel commented Jun 1, 2023 •
edited by cedoor
Loading

The VK_POINTS points variable storing the verification key points in the contract is not a constant.

The value will be stored in storage slots and would require reading every time. If this could be changed to a constant, the value will be part of the bytecode and verification will be cheaper (and also better performance I think).

Since this is an array it cannot be marked as constant directly, so other techniques need to be explored.
@saleel saleel added the feature 🚀 This is enhancing something existing or creating something new label Jun 1, 2023
@saleel saleel self-assigned this Sep 19, 2023
@saleel saleel mentioned this issue Sep 4, 2024
Open
@cedoor cedoor added the good first issue Good for newcomers label Sep 28, 2024
@cedoor cedoor moved this to ♻️ Grooming in Semaphore Board Sep 28, 2024
@cedoor cedoor added the hacktoberfest Encourages contributions to open source during Hacktoberfest. label Oct 3, 2024
@0xshikhar
Copy link
Contributor

Hey @cedoor, would love to work on this ? Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!

@cedoor
Copy link
Member

cedoor commented Oct 15, 2024

Hi @0xshikhar, this issue is part of #354. Let's sync here: #345 (comment)

@cedoor
Copy link
Member

cedoor commented Oct 15, 2024

@jimmychu0807 please, leave a comment here.

@jimmychu0807
Copy link
Contributor

Hi

@cedoor cedoor moved this from ♻️ Grooming to 🏗 In Progress in Semaphore Board Oct 15, 2024
@0xshikhar
Copy link
Contributor

Hi @0xshikhar, this issue is part of #354. Let's sync here: #345 (comment)

Sure, got it

jimmychu0807 added a commit to jimmychu0807/semaphore that referenced this issue Oct 16, 2024
@jimmychu0807
refactor(contracts): split SemaphoreVerifier verification key points …
d40a81e 
…into a separate library (semaphore-protocol#330)
jimmychu0807 added a commit to jimmychu0807/semaphore that referenced this issue Oct 16, 2024
@jimmychu0807
refactor(contracts): split SemaphoreVerifier verification key points …
a2bc9dc 
…into a separate library (semaphore-protocol#330)
@jimmychu0807 jimmychu0807 mentioned this issue Oct 16, 2024
Merged
7 tasks
@cedoor cedoor moved this from 🏗 In Progress to 👀 In review in Semaphore Board Oct 16, 2024
jimmychu0807 added a commit to jimmychu0807/semaphore that referenced this issue Oct 16, 2024
@jimmychu0807
refactor(contracts): update SemaphoreVerifierKeyPts library to be int…
93cd86b 
…ernal

re semaphore-protocol#330
cedoor pushed a commit that referenced this issue Oct 17, 2024
@jimmychu0807
Split SemaphoreVerifier key points into a separate library (#875)
79976f3 
* refactor(scripts): added a script to convert bigint to hex

* refactor(contracts): split SemaphoreVerifier verification key points into a separate library (#330)

* chore(contracts): yarn format & lint

* refactor(contracts): update SemaphoreVerifierKeyPts library to be internal

re #330

* chore(contracts): update spacing

* chore(contracts): updated per peer review and added invariant check for VerifierKeyPts lib

* chore(contracts): update invariant check to revert with custom error
@github-project-automation github-project-automation bot moved this from 👀 In review to ✔️ Done in Semaphore Board Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmychu0807 jimmychu0807

Labels
feature 🚀 This is enhancing something existing or creating something new good first issue Good for newcomers hacktoberfest Encourages contributions to open source during Hacktoberfest.
Projects
Semaphore Board
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split SemaphoreVerifier key points into a separate library jimmychu0807/semaphore
4 participants
@jimmychu0807 @cedoor @saleel @0xshikhar