Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default port to 443 for self-hosted #1054

Open
acco opened this issue Mar 3, 2025 — with Linear · 1 comment
Open

Default port to 443 for self-hosted #1054

acco opened this issue Mar 3, 2025 — with Linear · 1 comment

Comments

@acco Linear
Copy link
Contributor

acco commented Mar 3, 2025

Right now, we have one SERVER_PORT which conflates ports for the container (behind load balancer) with external ports (in front of the load balancer)

url in Phoenix is used to generate user-facing links. So we want these to correspond to the host/port that will hit the load balancer.

We should default this port to 443 and allow for overwriting it (which will not be common)
@girishramnani
Copy link
Contributor

seems like a small enough task - can I open a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acco @girishramnani