Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get forms out of FullPageModal #724

Open
acco opened this issue Dec 13, 2024 — with Linear · 1 comment
Open

Get forms out of FullPageModal #724

acco opened this issue Dec 13, 2024 — with Linear · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

Copy link
Contributor

acco commented Dec 13, 2024

Right now, consumer_form is a LiveComponent. We render it inside of the FullPageModal component because:

  • A full page modal is a nice UX pattern for displaying a form for create or edit: mentally, the user is still on the page where they clicked "Create/Edit"
  • We don't want to display the sidenav when displaying a form.

This works mostly well - however, there are some quirks. Whenever a tooltip is closed, the window scrolls to the top of the FullPageModal - not desirable.

We either want to:

  1. Determine why the scroll top behavior occurs - and fix it (we're using ShadCN Svelte).
  2. Move consumer_form into a LiveView. Just redirect to a different path when rendering the form. It should still feel like a full-page modal, but it won't be.
@acco acco added the enhancement New feature or request label Dec 13, 2024 — with Linear
@acco acco self-assigned this Dec 13, 2024
@mchavezi
Copy link

mchavezi commented Jan 7, 2025

Maybe on close have it go to an anchor link?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants