Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert/notify when a message is rejected due to size #937

Open
acco opened this issue Jan 31, 2025 — with Linear · 1 comment
Open

Alert/notify when a message is rejected due to size #937

acco opened this issue Jan 31, 2025 — with Linear · 1 comment
Labels
enhancement New feature or request

Comments

@acco Linear
Copy link
Contributor

acco commented Jan 31, 2025

A message may be rejected due to size:

  • There's a max message size of 5mb in the SlotProcessor (currently)
  • Some downstream sinks have max message sizes of their own (e.g. SQS)

We should log somewhere when these messages are rejected for users to review
@acco acco added the enhancement New feature or request label Jan 31, 2025 — with Linear
@RTLS
Copy link
Contributor

RTLS commented Jan 31, 2025

Good call out on ingestions vs. delivery failures due to max message size

These should probably be handled with different errors. For Sequin, we don't want to ingest at all. For downstream, we may want to treat this message as a normally failed message because some sinks have configurable max message sizes and users can re-configure their sink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acco @RTLS