Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Macros stripped by quasi_codegen::expand #65

Open
jdub opened this issue Nov 16, 2016 · 4 comments
Open

Macros stripped by quasi_codegen::expand #65

jdub opened this issue Nov 16, 2016 · 4 comments
Labels
bug

Comments

@jdub
Copy link

jdub commented Nov 16, 2016

Hi there,

I'm in the process of updating servo/rust-bindgen's aster/quasi/syntæx stack to the latest releases from *mumble* 0.28/0.20/0.44 respectively.

Using the new versions, some key context-sensitive macros are stripped during expansion -- is this a bug, or an intentional change?

You can see the chatter about this problem on rust-lang/rust-bindgen#270, including an example of the before/after expansion and stripped macro.

Thanks,
Jeff
@oli-obk
Copy link

oli-obk commented Nov 16, 2016

This is a bug: serde-rs/serde#608

@jdub
Copy link
Author

jdub commented Nov 16, 2016

@oli-obk Thanks for letting me know! Should I close this one? I'm not clear on which is the correct repo.

@oli-obk
Copy link

oli-obk commented Nov 16, 2016

neither am I, just leave it open, we'll close it together with the other issue

@dtolnay dtolnay added the bug label Nov 16, 2016
upsuper added a commit to upsuper-forks/rust-bindgen that referenced this issue Nov 17, 2016
@upsuper
Update quasi to 0.21
c007e84 
This is not the latest version, because the latest version doesn't work
due to serde-deprecated/quasi#65.

The issue of keeping using 0.20 is that libbindgen depends on aster 0.28
while quasi depends on aster 0.27, which leads to duplicate versions of
aster dependency. Updating quasi to 0.21 brings aster to 0.29, which
also works for libbindgen.
@upsuper upsuper mentioned this issue Nov 17, 2016
Merged
bors-servo pushed a commit to rust-lang/rust-bindgen that referenced this issue Nov 17, 2016
Auto merge of #275 - upsuper:update-quasi, r=emilio
3761ada 
Update quasi to 0.21

This is not the latest version, because the latest version doesn't work
due to serde-deprecated/quasi#65.

The issue of keeping using 0.20 is that libbindgen depends on aster 0.28
while quasi depends on aster 0.27, which leads to duplicate versions of
aster dependency. Updating quasi to 0.21 brings aster to 0.29, which
also works for libbindgen.
@upsuper
Copy link

upsuper commented Dec 10, 2016

FWIW, since servo has upgraded their syntex dependency to 0.50, and for integrating rust-bindgen into servo, we need to have matched version, we have worked around this issue by removing all macro_rules! in files which would be processed by quasi in rust-lang/rust-bindgen#329.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jdub @oli-obk @upsuper @dtolnay