Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test "passed" instead of "pending" #3

Open
christianbaumann opened this issue Feb 7, 2019 · 3 comments
Open

Test "passed" instead of "pending" #3

christianbaumann opened this issue Feb 7, 2019 · 3 comments

Comments

@christianbaumann
Copy link

Hi,

when running the first basic test, as described in the book, the expcted status is "test pending", but the actual status is "test passed":

10:05:46.749 [pool-1-thread-1] INFO  n.t.c.r.PackageRequirementsTagProvider - Loading requirements from package requirements at: starter
10:05:47.744 [pool-1-thread-1] INFO  n.t.c.steps.ConsoleLoggingListener -
        __    _____ _____ ____ _____   ____   _    ____  ____  _____ ____
  _     \ \  |_   _| ____/ ___|_   _| |  _ \ / \  / ___|/ ___|| ____|  _ \
 (_)_____| |   | | |  _| \___ \ | |   | |_) / _ \ \___ \\___ \|  _| | | | |
  _|_____| |   | | | |___ ___) || |   |  __/ ___ \ ___) |___) | |___| |_| |
 (_)     | |   |_| |_____|____/ |_|   |_| /_/   \_\____/|____/|_____|____/
        /_/

TEST PASSED: Adding sums

Any advice? Many thanks!

Christian

@wakaleo
Copy link
Member

wakaleo commented Feb 7, 2019

It will only be pending if it throws the PendingException

@christianbaumann
Copy link
Author

Ok, got it.
In the book, there´s the @pending annotation for addingSums(), which is not in the repo.

Thanks.

@ibrayem
Copy link
Contributor

ibrayem commented Apr 5, 2019

I have created a PR to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants