Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue with the xDS flow control functionality integration test #1742

Open
hanbingleixue opened this issue Jan 21, 2025 · 0 comments · May be fixed by #1743
Open

Fix the issue with the xDS flow control functionality integration test #1742

hanbingleixue opened this issue Jan 21, 2025 · 0 comments · May be fixed by #1743
Labels
kind/bug Something isn't working

Comments

@hanbingleixue
Copy link
Collaborator

hanbingleixue commented Jan 21, 2025

What happened?

  1. Added support for Okhttp2 2.2.0.
  2. The number of retry times is incorrect because the response header of HttpUrlConnection is not updated.
  3. The flow control configuration cannot obtain the millisecond-level time.
  4. Some retry conditions are inconsistent with Istio.

How can we reproduce it (as minimally and precisely as possible)?

  1. Use Okhttp2 2.2.0 to test the flow control function. The problem can be reproduced.
  2. When HttpUrlConnection is used to retry with a specified response header, the response header obtained after the retry is still the first response header, and the retry times are reached.
  3. The flow control function does not take effect when the time in the flow control matching configuration is set to ms.
  4. Retry conditions for link errors are configured. Retry is performed when the request times out.

Anything else we need to know?

No response

Sermant version

2.2.0

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here
@hanbingleixue hanbingleixue added the kind/bug Something isn't working label Jan 21, 2025
@hanbingleixue hanbingleixue linked a pull request Jan 21, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant