Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When deploy fails, some child processes seem to persist beyond the parent #222

Open
wmertens opened this issue Jun 27, 2023 · 2 comments
Open

Comments

@wmertens
Copy link

Most obvious when I'm doing --auto-rollback false. The deploy fails and returns to prompt, and after that I get the message πŸ‘€ ❌ [wait] [ERROR] Error waiting for activation: Timeout elapsed for confirmation.

@wmertens
Copy link
Author

wmertens commented Sep 2, 2023

I have further information on this: The process is activate-rs.

It might be because of my ssh configuration that uses a persistent connection with an auto master?

In any case, I'd expect that when I press Ctrl-C, the activate-rs SSH command also gets killed, and that when the deploy fails, the activate-rs is awaited.

@henrikvtcodes
Copy link

I also have experienced this. Sometimes even when a deploy succeeds a message will appear.

IMO the behavior should be to only exit once all processes have ended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants