-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise styling of the output #226
Milestone
Comments
Some other things that we have recently detected:
|
The
It currently uses the HttpExceptionContent's |
Never seen such long error message there before, we really need to provide custom error message for cases like that 👍 |
13 tasks
int-index
added a commit
that referenced
this issue
Nov 21, 2024
* cli: avoid spaces in metavar * errors: change formatting * tests: accept new output
int-index
added a commit
that referenced
this issue
Nov 21, 2024
* cli: avoid spaces in metavar * errors: change formatting * tests: accept new output
int-index
added a commit
that referenced
this issue
Nov 23, 2024
Problem: multiple issues with the CLI output 1. In the --help output, metavars GLOB_PATTERN and REPOSITORY_TYPE used spaces instead of underscores. Variables typically don't contain spaces in their names, so it looked confusing. 2. Incorrect or unintuitive coloring of the output. For example, filenames were dim even though they're important and should stand out, the report of success wasn't green, error messages weren't red, etc. 3. Excessive indentation and empty lines that made it difficult to visually parse the error report. Also the use of the exotic '➥' character that looks bad in many font configurations. 4. Filenames and line numbers were far apart, making it impossible to Ctrl+Click to jump to the source of the error. 5. In case of connection failure, the output was too verbose and platform-dependent. Solution: 1. Adjust the pretty-printing functions and update test output. 2. Extend VerifyError with a constructor for connection failures.
int-index
added a commit
that referenced
this issue
Dec 22, 2024
Problem: multiple issues with the CLI output 1. In the --help output, metavars GLOB_PATTERN and REPOSITORY_TYPE used spaces instead of underscores. Variables typically don't contain spaces in their names, so it looked confusing. 2. Incorrect or unintuitive coloring of the output. For example, filenames were dim even though they're important and should stand out, the report of success wasn't green, error messages weren't red, etc. 3. Excessive indentation and empty lines that made it difficult to visually parse the error report. Also the use of the exotic '➥' character that looks bad in many font configurations. 4. Filenames and line numbers were far apart, making it impossible to Ctrl+Click to jump to the source of the error. 5. In case of connection failure, the output was too verbose and platform-dependent. Solution: 1. Include the filename in positions returned by the scanner. 2. Adjust the pretty-printing functions and update test output. 3. Extend VerifyError with a constructor for connection failures.
int-index
added a commit
that referenced
this issue
Dec 22, 2024
Problem: multiple issues with the CLI output 1. In the --help output, metavars GLOB_PATTERN and REPOSITORY_TYPE used spaces instead of underscores. Variables typically don't contain spaces in their names, so it looked confusing. 2. Incorrect or unintuitive coloring of the output. For example, filenames were dim even though they're important and should stand out, the report of success wasn't green, error messages weren't red, etc. 3. Excessive indentation and empty lines that made it difficult to visually parse the error report. Also the use of the exotic '➥' character that looks bad in many font configurations. 4. Filenames and line numbers were far apart, making it impossible to Ctrl+Click to jump to the source of the error. 5. In case of connection failure, the output was too verbose and platform-dependent. Solution: 1. Include the filename in positions returned by the scanner. 2. Adjust the pretty-printing functions and update test output. 3. Extend VerifyError with a constructor for connection failures.
int-index
added a commit
that referenced
this issue
Dec 22, 2024
Problem: multiple issues with the CLI output 1. In the --help output, metavars GLOB_PATTERN and REPOSITORY_TYPE used spaces instead of underscores. Variables typically don't contain spaces in their names, so it looked confusing. 2. Incorrect or unintuitive coloring of the output. For example, filenames were dim even though they're important and should stand out, the report of success wasn't green, error messages weren't red, etc. 3. Excessive indentation and empty lines that made it difficult to visually parse the error report. Also the use of the exotic '➥' character that looks bad in many font configurations. 4. Filenames and line numbers were far apart, making it impossible to Ctrl+Click to jump to the source of the error. 5. In case of connection failure, the output was too verbose and platform-dependent. Solution: 1. Include the filename in positions returned by the scanner. 2. Adjust the pretty-printing functions and update test output. 3. Extend VerifyError with a constructor for connection failures.
int-index
added a commit
that referenced
this issue
Dec 22, 2024
Problem: multiple issues with the CLI output 1. In the --help output, metavars GLOB_PATTERN and REPOSITORY_TYPE used spaces instead of underscores. Variables typically don't contain spaces in their names, so it looked confusing. 2. Incorrect or unintuitive coloring of the output. For example, filenames were dim even though they're important and should stand out, the report of success wasn't green, error messages weren't red, etc. 3. Excessive indentation and empty lines that made it difficult to visually parse the error report. Also the use of the exotic '➥' character that looks bad in many font configurations. 4. Filenames and line numbers were far apart, making it impossible to Ctrl+Click to jump to the source of the error. 5. In case of connection failure, the output was too verbose and platform-dependent. Solution: 1. Include the filename in positions returned by the scanner. 2. Adjust the pretty-printing functions and update test output. 3. Extend VerifyError with a constructor for connection failures.
int-index
added a commit
that referenced
this issue
Dec 22, 2024
Problem: multiple issues with the CLI output 1. In the --help output, metavars GLOB_PATTERN and REPOSITORY_TYPE used spaces instead of underscores. Variables typically don't contain spaces in their names, so it looked confusing. 2. Incorrect or unintuitive coloring of the output. For example, filenames were dim even though they're important and should stand out, the report of success wasn't green, error messages weren't red, etc. 3. Excessive indentation and empty lines that made it difficult to visually parse the error report. Also the use of the exotic '➥' character that looks bad in many font configurations. 4. Filenames and line numbers were far apart, making it impossible to Ctrl+Click to jump to the source of the error. 5. In case of connection failure, the output was too verbose and platform-dependent. Solution: 1. Include the filename in positions returned by the scanner. 2. Adjust the pretty-printing functions and update test output. 3. Extend VerifyError with a constructor for connection failures.
int-index
added a commit
that referenced
this issue
Dec 22, 2024
Problem: multiple issues with the CLI output 1. In the --help output, metavars GLOB_PATTERN and REPOSITORY_TYPE used spaces instead of underscores. Variables typically don't contain spaces in their names, so it looked confusing. 2. Incorrect or unintuitive coloring of the output. For example, filenames were dim even though they're important and should stand out, the report of success wasn't green, error messages weren't red, etc. 3. Excessive indentation and empty lines that made it difficult to visually parse the error report. Also the use of the exotic '➥' character that looks bad in many font configurations. 4. Filenames and line numbers were far apart, making it impossible to Ctrl+Click to jump to the source of the error. 5. In case of connection failure, the output was too verbose and platform-dependent. Solution: 1. Include the filename in positions returned by the scanner. 2. Adjust the pretty-printing functions and update test output. 3. Extend VerifyError with a constructor for connection failures.
int-index
added a commit
that referenced
this issue
Dec 23, 2024
Problem: multiple issues with the CLI output 1. In the --help output, metavars GLOB_PATTERN and REPOSITORY_TYPE used spaces instead of underscores. Variables typically don't contain spaces in their names, so it looked confusing. 2. Incorrect or unintuitive coloring of the output. For example, filenames were dim even though they're important and should stand out, the report of success wasn't green, error messages weren't red, etc. 3. Excessive indentation and empty lines that made it difficult to visually parse the error report. Also the use of the exotic '➥' character that looks bad in many font configurations. 4. Filenames and line numbers were far apart, making it impossible to Ctrl+Click to jump to the source of the error. 5. In case of connection failure, the output was too verbose and platform-dependent. Solution: 1. Include the filename in positions returned by the scanner. 2. Adjust the pretty-printing functions and update test output. 3. Extend VerifyError with a constructor for connection failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clarification and motivation
Look at the readme, at how the output looks like.
This is all subjective, but there are things that feel like a bad design of the style:
-
beforetext
,link
, andanchor
look redundant, especially after Avoid exotic unicode symbols #202.Let's discuss all this and apply some fixes before the release.
Acceptance criteria
The text was updated successfully, but these errors were encountered: