You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the solution for #211, Xrefcheck treats anchors as case-sensitive or case-insensitive depending on the configured markdown flavour. However, they are still being represented as Text and we have to take this configuration into account every time that we use them, which can be missed when implementing new features.
A possible solution is to create a wrapper type for anchors and to apply some of the following ideas:
Do not allow to compare them unless explicitly taking the configured markdown into account.
Make its Eq instance implementation depend on the configured markdown.
Allow to extract a canonical (regarding case-sensitivity) Text value from it with a function that depends on the configured markdown, which will be used for comparison-related checks.
Acceptance criteria
Having explored the proposed ideas or proposed a new one.
Having implemented one of them in order to make the anchors case-sensitivity feature easier to manage and more maintainable.
The text was updated successfully, but these errors were encountered:
Clarification and motivation
With the solution for #211, Xrefcheck treats anchors as case-sensitive or case-insensitive depending on the configured markdown flavour. However, they are still being represented as
Text
and we have to take this configuration into account every time that we use them, which can be missed when implementing new features.A possible solution is to create a wrapper type for anchors and to apply some of the following ideas:
Eq
instance implementation depend on the configured markdown.Text
value from it with a function that depends on the configured markdown, which will be used for comparison-related checks.Acceptance criteria
The text was updated successfully, but these errors were encountered: