Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the case of two external links that differ only in anchors #266

Open
Martoon-00 opened this issue Jan 12, 2023 · 0 comments
Open

Comments

@Martoon-00
Copy link
Member

Clarification and motivation

We do not check anchors of external links, so if two links differ only in anchor, we could consider them as "same" and perform only one poll for both.

Note that we already have a mechanism for avoiding two requests for two links that are exactly the same, and now we should carefully extend that; carefully because we rely on "same" notion to designate the same thing in several places. Maybe introduce one more newtype-wrapper, this type for external links.

Acceptance criteria

  • For several external links that differ only in anchor we perform one request.
  • We've considered which other parts of the URI are irrelevant for our checker, and got transparent over them too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant