Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advancements #165

Closed
mplatypus opened this issue Jul 23, 2022 · 7 comments
Closed

Advancements #165

mplatypus opened this issue Jul 23, 2022 · 7 comments
Assignees

Comments

@mplatypus
Copy link

add an event for advancements, and also the ability to check all advancements

@phybros
Copy link
Collaborator

phybros commented Sep 8, 2022

I can make a basic API at /v1/advancements which would produce something like

[
  {
    "name": "story/enter_the_end",
    "criteria": [
      "entered_end"
    ]
  },
  {
    "name": "husbandry/complete_catalogue",
    "criteria": [
      "textures/entity/cat/tabby.png",
      "textures/entity/cat/white.png",
      "textures/entity/cat/black.png",
      "textures/entity/cat/jellie.png",
      "textures/entity/cat/siamese.png",
      "textures/entity/cat/ragdoll.png",
      "textures/entity/cat/british_shorthair.png",
      "textures/entity/cat/all_black.png",
      "textures/entity/cat/persian.png",
      "textures/entity/cat/red.png",
      "textures/entity/cat/calico.png"
    ]
  },
  {
    "name": "recipes/decorations/light_gray_bed_from_white_bed",
    "criteria": [
      "has_bed",
      "has_the_recipe"
    ]
  },
  {
    "name": "recipes/decorations/light_gray_stained_glass_pane",
    "criteria": [
      "has_glass",
      "has_the_recipe"
    ]
  },
  {
    "name": "recipes/building_blocks/bone_block",
    "criteria": [
      "has_bone_meal",
      "has_the_recipe"
    ]
  }
]

Is there any other info we should include on each advancement @mplatypus ?

I know you also asked for a new Event when someone gets an Advancement, I will work on that next. Let me know what you think.

@mplatypus
Copy link
Author

that looks awesome! do you know if it would work with other mods that add different advancements?

@phybros
Copy link
Collaborator

phybros commented Sep 8, 2022

@mplatypus if you have an example I can install it and test

@mplatypus
Copy link
Author

the datapack is called Blaze and Caves advancements

@phybros
Copy link
Collaborator

phybros commented Sep 8, 2022

Yeah seems to work fine. I got bacap/advancement_legend and end/good_luck_getting_this_one which I think are both from that datapack.

Were you thinking we should also have a player API for them? like /v1/players/:id/advancements that shows all the advancements for a specific player?

@phybros phybros self-assigned this Sep 8, 2022
@mplatypus
Copy link
Author

yeah that'd be awesome to grab all their advancements

@phybros
Copy link
Collaborator

phybros commented Apr 11, 2023

Going to close this since we added the basic advancements API back in 0.4.0. Getting advancements for specific players is a lot more convoluted, so I'll open a new issue for that.

@phybros phybros closed this as completed Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants