Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circle slot #232

Closed
2 tasks done
setaman opened this issue Mar 24, 2024 · 1 comment · Fixed by #240
Closed
2 tasks done

Add circle slot #232

setaman opened this issue Mar 24, 2024 · 1 comment · Fixed by #240
Assignees
Labels
feature feature request
Milestone

Comments

@setaman
Copy link
Owner

setaman commented Mar 24, 2024

Extend the slots to allow users to completely replace rendered circles and paths. This will provide maximum flexibility for the users but also require more responsibility.

Core goals

  • Users should have more control over the resulting SVG, enabling them to easily add additional styles and customize the appearance
  • Users should be able to provide custom SVG figures, such as an ellipse or a custom path
  • The plugin should expose the internal calculations used to determine values like position, radius, circumference, etc., through the slots. This will empower users to directly apply these values to custom SVG elements

Acceptance criteria

  • The plugin exposes scoped slots for progress circle
  • Scoped slots should expose internally calculated values, including position, radius, path, as well as styles, classes, and animation-related properties, that are used to render the default circles
@setaman setaman self-assigned this Mar 24, 2024
@setaman setaman converted this from a draft issue Mar 24, 2024
@setaman setaman added this to the v2 milestone Mar 24, 2024
@setaman
Copy link
Owner Author

setaman commented Mar 24, 2024

could cover #104

@setaman setaman removed the status in vue-ellipse-progress Mar 24, 2024
@setaman setaman moved this to 📜 Backlog in vue-ellipse-progress Mar 24, 2024
@setaman setaman added the feature feature request label Mar 24, 2024
@setaman setaman linked a pull request Aug 24, 2024 that will close this issue
@setaman setaman moved this from 📜 Backlog to ⚒️ In progress in vue-ellipse-progress Aug 30, 2024
@setaman setaman closed this as completed Oct 4, 2024
@github-project-automation github-project-automation bot moved this from ⚒️ In progress to ✅ Done in vue-ellipse-progress Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant