Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n stuff #33

Open
sftcd opened this issue Jul 7, 2024 · 3 comments
Open

i18n stuff #33

sftcd opened this issue Jul 7, 2024 · 3 comments

Comments

@sftcd
Copy link
Owner

sftcd commented Jul 7, 2024

This is just a holding issue to check we have no i18n issues with e.g. names as we transit between JSON and DNS RR values.

@bemasc
Copy link
Collaborator

bemasc commented Jul 8, 2024

I think the SvcParams are covered by the reference to isomorphic decode:

so each value octet is stored as a single Unicode codepoint

The TargetName currently doesn't have this text though, which leaves some ambiguity about what to do with TargetNames like "asdf.☃.example.com".

@davidben
Copy link

For asdf.☃.example.com, is it not sufficient to just say that the target names are A-labels. (Or U-labels, whichever is easier for the zone factory. I'm guessing A-labels will be easier?)

@bemasc
Copy link
Collaborator

bemasc commented Jul 24, 2024

Yep, something like that would be fine.

EDIT: Note that A-label names are a subset of all DNS names, because DNS labels are formally 8-bit-clean octet sequences. So either we restrict TargetName to be an ASCII-compatible subset of DNS names, or we need to apply something like isomorphic decode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants