Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add larivaar #136

Closed
saihaj opened this issue May 2, 2020 · 8 comments
Closed

Add larivaar #136

saihaj opened this issue May 2, 2020 · 8 comments

Comments

@saihaj
Copy link
Member

saihaj commented May 2, 2020

shabados/theme-tool#1 (comment)
I think this will also be useful for mobile.

@sarabveer
Copy link
Collaborator

@Harjot1Singh do we want to include larivaar in gurmukhi-utils or just do in in app.

@Harjot1Singh
Copy link
Member

@Harjot1Singh do we want to include larivaar in gurmukhi-utils or just do in in app.

I think it may be worth moving this into GU. Do you think others, or yourself would find it useful?

@sarabveer
Copy link
Collaborator

sarabveer commented May 3, 2020

Sure, it could be moved into GU. I personally replace spaces with Zero-Width Spaces (U+200B) for Larivaar.

How would GU implement assist though, isn't that up to the app?

@saihaj
Copy link
Member Author

saihaj commented May 3, 2020

Yeah assist will depend on the app

@saihaj saihaj changed the title Add larivaar and larivaar assist Add larivaar May 3, 2020
@bhajneet
Copy link
Member

Closing without resolution. This issue either affects too few users or there are too many issues with higher impact to be working on. It is possible to re-open or re-visit this issue at a later time. If you feel this issue is important, please give a thumbs-up reaction to the first post. You may track this issue from the pinned meta-tracker at the top of the issues home page.

@sarabveer
Copy link
Collaborator

I thought about this more, and I realized this would be useful. Currently I have a set of regex lookups that properly format for larivaar.

I will look into implementing this sooner or later.

@sarabveer sarabveer reopened this Nov 7, 2020
@bhajneet
Copy link
Member

bhajneet commented Nov 7, 2020

Can you give an example of how it's helpful? We just remove spaces at this time, so wondering what else is happening with regex

@bhajneet
Copy link
Member

I still have no idea if there is a benefit to this function (which as far as I know simply strips whitespace), so closing for now, but open to implementing it if given some logic/programming requirements

@github-project-automation github-project-automation bot moved this from Triage to In Testing in Project Management Jul 21, 2023
@Harjot1Singh Harjot1Singh moved this from In Testing to Done in Project Management Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants