Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Examining and Optimizing Previous Material Objects #270

Open
csdechant opened this issue Jan 16, 2025 · 0 comments
Open

Re-Examining and Optimizing Previous Material Objects #270

csdechant opened this issue Jan 16, 2025 · 0 comments

Comments

@csdechant
Copy link
Collaborator

csdechant commented Jan 16, 2025

This issues is inspired by a conversation in PR #265 (comment below for reference). To summarized, due to the ongoing development of Zapdos, previous material objects should be re-examined to see if any declare property are not being utilized in a current test and address the need for a test or the removal of the property.

This object was made during Alex's thesis and I haven't used it except when I was first using Zapdos. After a quick search in Zapdos, it doesn't seem that any of the test files used this exact material property. That being said, I don't think we should remove it for this PR, as this and other material objects (such as Gas.C and GasElectronMoments) should be re-examined to see if any declare property are not being utilized in a current test and address the need for a test or the removal of the property.

Originally posted by @csdechant in #265 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant