Missing magic changed to be a unique error vs a parsing error #440
Conversation
…arsers for framing data from streams is easier
Will do! Shoulda marked this as a draft while I was working on that, apologies. |
|
What version of the toolchain is being used, compiler outputs being used for tests without pinning a version is what's causing some of these CI failures. I had been on a nightly 1.80 which apparently changes the output of the compiler, fun fun! |
Yah I usually use |
| /// Deku errors | ||
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| #[non_exhaustive] | ||
| pub enum DekuError { | ||
| /// Parsing error when reading | ||
| Incomplete(NeedSize), | ||
| /// Failed to find magic | ||
| Framing(NeedMagic), |
There was a problem hiding this comment.
would prefer the name relate to magic, unless we plan on expanding this to be an enum with different variants
This change is needed so parsers that work on stream data can know wether to advance into the buffer to find a valid message without having to manually search for magic bytes before feeding the DekuRead object.