Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The construction of discriminator #11

Open
YifanZuo opened this issue Sep 7, 2017 · 1 comment
Open

The construction of discriminator #11

YifanZuo opened this issue Sep 7, 2017 · 1 comment

Comments

@YifanZuo
Copy link

YifanZuo commented Sep 7, 2017

I have a question on the discriminator construction. I find the final number of channel is "1" via convolutional layer in this implementation. However, I find in others, e.g., "improved wgan", the final layer is fully-connection layer with the out dimension "1".
So, which one is better? Indeed, I do not find any description of discriminator construction in the original paper (Wasserstein GAN).

@YifanZuo
Copy link
Author

YifanZuo commented Sep 8, 2017

Now,I confirm that this implementation has two errors. One is the optimizer should be rmsprop but not adam. The other is that the final output must use fully-connection to get one scalar according to the original paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant