Skip to content

Latest commit

 

History

History
27 lines (19 loc) · 1.03 KB

File metadata and controls

27 lines (19 loc) · 1.03 KB

Furry Berry Armadillo

Medium

some functions are not fully compliant with EIP-4626

Description

withdraw

MUST revert if all of assets cannot be withdrawn (due to withdrawal limit being reached, slippage, the owner not having enough shares, etc).

withdrawal limit being reached inst check

previewWithdraw

MUST be inclusive of withdrawal fees. Integrators should be aware of the existence of withdrawal fees.

previewDeposit

MUST be inclusive of deposit fees. Integrators should be aware of the existence of deposit fees.

Recommendation

All functions listed above should be modified to meet the specifications of EIP-4626