Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive for: A List of Websites #2273

Open
1 task done
MrGranddy opened this issue Aug 26, 2024 · 2 comments
Open
1 task done

False positive for: A List of Websites #2273

MrGranddy opened this issue Aug 26, 2024 · 2 comments
Labels
false positive A site is responding with false positives

Comments

@MrGranddy
Copy link

MrGranddy commented Aug 26, 2024 •
edited
Loading

Additional info

https://cavalier.hudsonrock.com/
https://hackenproof.com/
https://forum.hackthebox.com/
https://www.librarything.com/
https://lichess.org/
https://www.tldrlegal.com/

I was going to create a PR for the fix, yet I am extremely disappointed to see that the codebase is not Pythonic at all. It gave me headaches. I hope you'll fix these FPs and find salvation in PEP8.

Additional Information:

  • OS Windows
  • Tried with several usernames, consistently getting these FPs

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MrGranddy MrGranddy added the false positive A site is responding with false positives label Aug 26, 2024
@MrGranddy MrGranddy changed the title False positive for: False positive for: A List of Websites Aug 26, 2024
@rsb-23
Copy link
Contributor

rsb-23 commented Sep 3, 2024 •
edited
Loading

tldrlegal have same response for all users, hence can't be fixed.
I have fixed the rest.

rsb-23 added a commit to rsb-23/sherlock that referenced this issue Sep 3, 2024
@rsb-23
Fixed false positives sherlock-project#2273
192e2c3 
- Updated user-agent in header and removed duplicate
-
@rsb-23
Copy link
Contributor

rsb-23 commented Sep 3, 2024

I too would suggest to add more linters to code, maybe using pre-commit and pyproject.toml for config.
This will make code more consistent and maintainable.

@rsb-23 rsb-23 mentioned this issue Sep 22, 2024
Open
1 task
ppfeister added a commit that referenced this issue Nov 12, 2024
@ppfeister
Merge pull request #2285 from rsb-23/master
46023a8 
Fixed false positives #2273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false positive A site is responding with false positives
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MrGranddy @rsb-23 and others