Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display regression in eltview #693

Open
maethor opened this issue Dec 18, 2018 · 8 comments
Open

Display regression in eltview #693

maethor opened this issue Dec 18, 2018 · 8 comments

Comments

@maethor
Copy link
Contributor

maethor commented Dec 18, 2018

@mohierf your style commits have bad effects in eltviews (and maybe elsewhere).

This is the webui in commit 87e75f3

2018-12-18-165021_1916x1156_scrot

This is latest develop

2018-12-18-165341_1916x1156_scrot

As you can see, in latest version action menu doesn't work properly and we lost some margins.

I don't know which commit(s) causes theses problems. Can I let you find out and fix everything?

@maethor
Copy link
Contributor Author

maethor commented Dec 18, 2018

Also in the left menu there is margins and alignments problems between icons and labels. And I don't want this border at the right of the menu if we can about it.

Please avoid to make CSS ajustments like this. I don't think we need that kind of change and it is very painful to debug.

@mohierf
Copy link
Contributor

mohierf commented Dec 19, 2018

I simply reduced the left margin containing the main menu and for the actions menu I used the same style as the main menu. This is a consequence of the style relooking to get a responsive UI. And I simply did not restored the former style (color and margins) in the actions menu.

I tested all the commands on my test environment and everything is functional.

Could you be more precise about the misalignemnt problems you observed ? About lost margin ? Actions menu problems ?

@mohierf
Copy link
Contributor

mohierf commented Dec 19, 2018

More observations;

  • the recheck command raises two external commands ... like if the button is clicked twice!

@maethor
Copy link
Contributor Author

maethor commented Dec 19, 2018

I cannot be more precise that the two screenshots. Don't you see the differences?

@mohierf
Copy link
Contributor

mohierf commented Dec 19, 2018

Differences are only the margins ... and I did not see any layout problem with these margins ... a cache problem ?

@maethor
Copy link
Contributor Author

maethor commented Jan 2, 2019

I am talking about the margins :)

@maethor
Copy link
Contributor Author

maethor commented Jan 23, 2019

I just fixed this margins problem, and some other miscellanious details in this page.

About the actions menu. Both here and in the dashboard I think I will move it to the right of the page title / breadcrumb. The drawback is that actions will not be accessible when we scroll down, but I think it will be more elegant than this buggy action menu. What do you think @mohierf ?

Alternatively, I can reduce this menu to only one line of icons, and keep it at the bottom of the sidebar.

@mohierf
Copy link
Contributor

mohierf commented Jan 24, 2019

Why not ... I think it can be a good idea! Indeed, it may be CSS fixed to remain on screen whe scrolling down ... like the minemap table header is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants