Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search engine - search on item name #699

Open
2 tasks
mohierf opened this issue Dec 21, 2018 · 2 comments
Open
2 tasks

Search engine - search on item name #699

mohierf opened this issue Dec 21, 2018 · 2 comments
Labels

Comments

@mohierf
Copy link
Contributor

mohierf commented Dec 21, 2018

Using a simple term (eg server) in the search engin will make it search for all items which name contains the searched term.

As of now, the search is done like this, for each item:

  • regex search of the term in the item full name (eg host_name for an host nad host_name/service_description for a service)
  • else, search in the alias property only for hosts
  • else, search in the item impacts and source problems name then alias
  1. What about searching also in the aliasof the services ?
  2. and then, searching in the display_name of hosts and services ?
  3. and then, searching in the notes of the hosts/services ?

It may be interesting to extend the search engine with these capabilities.
Indeed, it may be logical to search first in the display_name ... because we are an UI and display_name is made for the UI 😉

Search order may be:

  • display_name

  • alias

  • host_name / service_description

  • notes

  • implement this search order

Searching in the item impacts and source problems name does not make sens to me! If I am search for an host or service named db_server I do not care finding the switch it is attached to because the switch is a root problem of my DB server!

  • remove the search on impacts and source problems based on names
@mohierf
Copy link
Contributor Author

mohierf commented Dec 21, 2018

Note that if the pattern is not matching anything in the former search step, the search engine will then search in the items last check output and then in the impacts and source problems output of the items ... pfewww!

Then, for each item:

  • the last check output
  • else, the item impacts and source problems last check output

@maethor
Copy link
Contributor

maethor commented Jan 2, 2019

IIRC Shinken doesn't allow to define an alias on a service, so it is pointless to allow searching on service aliases.

About impacts, I'm not sure, I need to think about it.

But if your want to add a fallback search into notes, I'm OK with it.

mohierf added a commit to mohierf/mod-webui that referenced this issue Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants