Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Layer/Group shadow effect #3

Closed
vpdn opened this issue Jun 2, 2014 · 4 comments
Closed

Feature Request: Layer/Group shadow effect #3

vpdn opened this issue Jun 2, 2014 · 4 comments
Assignees

Comments

@vpdn
Copy link

vpdn commented Jun 2, 2014

Layershots is in the process of moving from the original PDFWriter to SFPSDWriter to add folder support. Thanks a lot for your work maintaining this library!

For rendering a CALayer's shadow properly onto a psd file, support for group effects would be superb (Issue #10).

I would be happily bribing you with cold beverages for the next time you make it from Parma up to Germany 😃

@nerolapis
Copy link
Collaborator

Just to make sure I understood correctly I make a summary.

This is the current state of the problem:

  • the shadow of the CALayer is rendered as a raster image into the PSD layer

What is asked:

  • add the "Drop Shadow" effect support on the layers (and the groups)

If this is the point - I'll investigate the PSD references in order to understand how much time and effort will it take to implement this effect.

I'll keep you updated. ;)

@nerolapis nerolapis self-assigned this Jun 10, 2014
@vpdn
Copy link
Author

vpdn commented Jun 10, 2014

Yeah, currently Layershots renders the shadow into a rasterized psd layer. Which is not ideal because it produces a wrong result, when a child layer extends beyond the parent's bounds for example. CALayer shadow (and other properties such as border stroke) works much more like an effect on a PSD group, which affects all children as well. So yeah, group effect support would be absolutely fantastic!

@nerolapis
Copy link
Collaborator

Ok - I've found the PSD section concerning the "drop shadow" effect.

In the next days I'll make some experiments and let you know the results! :)

@nerolapis
Copy link
Collaborator

The 21e81c4 commit adds the wanted functionality. The Pod should be validated and updated.

Check out if it works; I haven't tried it in a real world project but I made tests with the test projects.

If you'll encounter any problem - don't hesitate to drop a note.

The next time in Germany I'll pass by for a beer! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants