Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Infinite metal glitch #2406

Closed
Thera-Pissed opened this issue Oct 15, 2023 · 0 comments
Closed

[BUG] Infinite metal glitch #2406

Thera-Pissed opened this issue Oct 15, 2023 · 0 comments
Labels
Bug Something isn't working

Comments

@Thera-Pissed
Copy link
Contributor

Round ID: 1943

Testmerges:

#2213: '(Re) Adds meteor shields' by Bjarl at commit 951e17bb35
#2262: 'Cepheus nerfs' by Bjarl at commit 75a4f97d5a
#1898: 'Adds a new ruin, The Cave Crew!' by spockye at commit 34c406bbad
#2357: 'Berbs' by MarkSuckerberg at commit 624707963c
#2250: 'outpost tweaks & fixes: Vengeance ' by goober3 at commit 441462578a
#2365: 'Maploader Optimisations' by MarkSuckerberg at commit 44dc5d3eed
#2363: 'Adds a crashed pubby as a sand world ruin' by immortalartisan at commit e5adb4eb5d
#1601: 'Gun rework' by retlaw34 at commit 2464123e6b
#2384: 'Adds the Nomad crash site to the rockplanet' by Zytolg at commit fbb8ec7a01
#2371: 'Adds the Floating Resort ruin to Beaches!' by Zytolg at commit 116c13c7c7
#2379: 'Removes mentions of Russians, Capitalism/Stalinium Golems, Derelict Drone Subtype, Tweaks AI Ion Laws' by meemofcourse at commit 756e0f9c5d
#2374: 'Crate shelf' by GenericDM at commit 6f5f7d1d16
#2391: 'Adds a metric fuckton of pAI faces' by retlaw34 at commit 9e3966ae4d
#2358: 'Genericises multi-dock prevention' by MarkSuckerberg at commit 783ca33aca
#2385: 'Adds the Inkwell-class Supply Freighter' by Imaginos16 at commit 9dcd801a07
#2316: 'Better metal rod throwing feedback' by retlaw34 at commit c0b1db6bd3

Reproduction:

image
image
The floor tiles are "ripped up" by the disposals pipes, but aren't destroyed. They still give metal
Shiptest cobblegen real
this config makes infinite metal

@Thera-Pissed Thera-Pissed added the Bug Something isn't working label Oct 15, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 17, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Fixes the following issues
#2406 
#2405 
#2400 
#2390 
#2255 & #2356 
Plus the unlisted issues of vending machines lying about their stuff
being free, jukebox sprites being broken, and mobs being able to play
container opening sounds from anywhere so long as the container was on
screen.

Also prevents fish from starving to death while in aquariums and instead
makes them heal while well fed.

## Why It's Good For The Game

Bug fixes are always good and I've yet to hear anyone have anything but
middling hate for the fish starvation mechanics.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
tweak: fish should no longer starve to death
fix: the mech equipment panel works again
fix: limbgrower legs should no longer runtime instead of spawning
fix: crystal legion hearts inheriting the wrong sprites
fix: vending machines falsely listing their prices as "free"
fix: normal fulltile firelocks should build properly now
fix: disposal pipes no longer generate metal when ejecting items through
reinforced plating
fix: jukebox sprites
fix: players can no longer telepathically fiddle with the zippers of
bags
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants