Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing FQDN/hostname option for windows #1572

Open
patryk4815 opened this issue Dec 21, 2023 · 2 comments
Open

Missing FQDN/hostname option for windows #1572

patryk4815 opened this issue Dec 21, 2023 · 2 comments
Labels
package:host v4

Comments

@patryk4815
Copy link

patryk4815 commented Dec 21, 2023 •
edited
Loading

Missing FQDN option for windows:

Example implementation:
https://github.com/elastic/go-sysinfo/blob/main/providers/windows/host_windows.go#L88C44-L88C81

os.Hostname() don't return full hostname on windows
@shirou
Copy link
Owner

shirou commented Dec 24, 2023

Indeed, this might be a good feature to have. And it looks like it could be implemented on all platforms. Thanks for the suggestion.

@john-behm-bertelsmann
Copy link

might make sense to introduce a FQDN() function instead of changing the Hostname()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:host v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shirou @patryk4815 @john-behm-bertelsmann