Switch value, is it an error?

[DbrRoxane]

Hi,

There are, I think a few errors regarding your switch values

I would change 0 per 3 in l315 and 3 per 0 in l281.

qa-hard-em/prepro.py

Line 315 in 5620861

switches.append(0)

qa-hard-em/prepro.py

Line 281 in 5620861

if orig_answer_text not in ['yes', 'no'] or switch == 3:

Does it make sense?

[shmsw25]

Hi @DbrRoxane, for L315, it actually won't matter because the answer mask is 1. For L281, it should be "3" as it means there is no answer ("1" and "2" are yes and no, respectively; so the purpose of this line is to only consider "0" which is a valid span answer).

[DbrRoxane]

Hi

OK for the first one but for the last one, I am a bit confused because I understood the value 3 is for no answer, but I thought that here we would mean 0. Because I need to have an answer to assign start/end position ; while in the else start/end position are just 0.

[shmsw25]

Oh I got it. You are correct. It should be 0 or be changed into switch!=3. Thanks for catching! It shouldn't affect the performance though and will only cause the delay in preprocessing by processing unnecessary extra answers.