Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated documentation linting #755

Closed
swsrmes opened this issue Oct 20, 2022 · 3 comments
Closed

Automated documentation linting #755

swsrmes opened this issue Oct 20, 2022 · 3 comments
Assignees
Labels
DX Team #dev-docs Improvement PR created to append/modify info in the existing article

Comments

@swsrmes
Copy link
Contributor

swsrmes commented Oct 20, 2022

Since there are many new, exciting changes happening within the Shopware documentation space, and many concrete processes being established therein, I see a prime opporunity for establishing automated jobs within the documentation PR flow.

An obvious facet is spellchecking, which could be achieved using Github actions such as this. I attempted this previously, but I am currently stuck, with the issue persisting that pyspelling doesn't seem to understand the markdown correctly, despite a markdown extension being added/configured. Given it uses non-vanilla markdown syntax, it could be worth writing some customised regex filters for the extended markdown token set.

There is also a great opportunity to establish documentation linters, which will catch obvious and lexically concrete errors or issues, such as heading casing or flagging date-time format.

In order to achieve such automated enforcing/linting of documentation lexical style rules, we could consider a configurable tools such as TextLint

This could limit the number of mistakes reaching the review stage, and limit load on the reviewers of the docs.

@sushmangupta
Copy link
Collaborator

Thank you for the suggestion. We have noted and shall consider incorporating it.

@sushmangupta sushmangupta added Improvement PR created to append/modify info in the existing article DX Team #dev-docs labels Oct 26, 2022
@Isengo1989 Isengo1989 self-assigned this Nov 17, 2023
@Isengo1989
Copy link
Collaborator

@swsrmes short update - we are currently looking into the options here and compare the given actions with other to use the best option for our docs 👍

@Isengo1989
Copy link
Collaborator

Isengo1989 commented Nov 29, 2023

@swsrmes we did implement (some PRs pending) the following:

  • Spellchecker with own dictionary (.wordlist.txt) - see here
  • Languagetool for additional grammar, language and other checks (POC - will be adjusted) - see here
  • Filename checks - see here

As for the datetime, we decided to move along without it, since we do have many date formats from different places and code examples. Filtering those out leaves us just with a few, which is not worth the additional effort. Feel free to create a PR on action / workflow that might does that.

The issue will be closed - thank you for the input 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Team #dev-docs Improvement PR created to append/modify info in the existing article
Projects
None yet
Development

No branches or pull requests

4 participants