From 37d1976a178e2288963f35829e342289bea83e08 Mon Sep 17 00:00:00 2001 From: Nils Haberkamp Date: Thu, 8 Feb 2024 14:04:56 +0100 Subject: [PATCH] NEXT-33446 - move job to check for circular dependencies to root --- .github/workflows/tests.yml | 25 +++++++++++++++++++ .../admin-sdk/.github/workflows/tests.yml | 21 ---------------- 2 files changed, 25 insertions(+), 21 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index b69e35290..ab51e7198 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -65,3 +65,28 @@ jobs: - name: unit run: pnpm run test:unit + + circular-dependencies: + name: Check for circular dependencies (Madge) + runs-on: ubuntu-latest + env: + TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }} + TURBO_TEAM: ${{ secrets.TURBO_TEAM }} + steps: + - name: Checkout + uses: actions/checkout@v2 + + - uses: pnpm/action-setup@v2 + with: + version: 8 + + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + node-version: '20' + + - name: Install dependencies + run: pnpm install + + - name: madge + run: pnpm --filter @shopware-ag/meteor-admin-sdk run circular-dependencies diff --git a/packages/admin-sdk/.github/workflows/tests.yml b/packages/admin-sdk/.github/workflows/tests.yml index 9b200589e..24bc41b52 100644 --- a/packages/admin-sdk/.github/workflows/tests.yml +++ b/packages/admin-sdk/.github/workflows/tests.yml @@ -3,27 +3,6 @@ name: Tests on: push jobs: - circular-dependencies: - name: Circular dependencies (Madge) - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v2 - - name: Setup Node.js - uses: actions/setup-node@v2 - with: - node-version: '18' - - name: Retrieve the cached "node_modules" directory (if present) - uses: actions/cache@v2 - id: node-cache - with: - path: node_modules - key: node-modules-${{ runner.os }}-${{ hashFiles('package-lock.json') }} - - name: Install dependencies (if the cached directory was not found) - if: steps.node-cache.outputs.cache-hit != 'true' - run: npm ci - - name: madge - run: npm run circular-dependencies playwright-run: name: Playwright Integration Tests timeout-minutes: 20