diff --git a/.changeset/serious-avocados-destroy.md b/.changeset/serious-avocados-destroy.md new file mode 100644 index 000000000..e3aef71bd --- /dev/null +++ b/.changeset/serious-avocados-destroy.md @@ -0,0 +1,5 @@ +--- +"@shopware-ag/meteor-component-library": patch +--- + +Improve a11y of help text diff --git a/packages/component-library/src/components/form/mt-help-text/mt-help-text.vue b/packages/component-library/src/components/form/mt-help-text/mt-help-text.vue index 58dc6c153..726ba49c2 100644 --- a/packages/component-library/src/components/form/mt-help-text/mt-help-text.vue +++ b/packages/component-library/src/components/form/mt-help-text/mt-help-text.vue @@ -1,5 +1,5 @@ - diff --git a/packages/component-library/src/components/navigation/mt-link/mt-link.interactive.stories.ts b/packages/component-library/src/components/navigation/mt-link/mt-link.interactive.stories.ts index 374602f5d..d1d9dbf38 100644 --- a/packages/component-library/src/components/navigation/mt-link/mt-link.interactive.stories.ts +++ b/packages/component-library/src/components/navigation/mt-link/mt-link.interactive.stories.ts @@ -1,5 +1,4 @@ -import { within } from "@storybook/test"; -import { expect } from "@storybook/test"; +import { expect, userEvent, within } from "@storybook/test"; import meta, { type MtLinkMeta, type MtLinkStory } from "./mt-link.stories"; @@ -27,11 +26,11 @@ export const VisualTestRenderExternalLinkDisabled: MtLinkStory = { args: { disabled: true, }, - play: async ({ canvasElement }) => { + play: async ({ canvasElement, args }) => { const canvas = within(canvasElement); - const link = canvas.getByText("Link"); + await userEvent.click(canvas.getByRole("link")); - expect(getComputedStyle(link).pointerEvents).toEqual("none"); + expect(args.click).not.toHaveBeenCalled(); }, }; diff --git a/packages/component-library/src/components/navigation/mt-link/mt-link.stories.ts b/packages/component-library/src/components/navigation/mt-link/mt-link.stories.ts index 548cf4d38..0352588ac 100644 --- a/packages/component-library/src/components/navigation/mt-link/mt-link.stories.ts +++ b/packages/component-library/src/components/navigation/mt-link/mt-link.stories.ts @@ -4,13 +4,13 @@ import { fn } from "@storybook/test"; import MtLink from "./mt-link.vue"; import type { SlottedMeta } from "@/_internal/story-helper"; -export type MtLinkMeta = SlottedMeta; +export type MtLinkMeta = SlottedMeta; export default { title: "Components/Navigation/mt-link", component: MtLink, args: { - as: "router-link", + as: "a", default: "Link", to: "/", variant: "primary", diff --git a/packages/component-library/src/components/navigation/mt-link/mt-link.vue b/packages/component-library/src/components/navigation/mt-link/mt-link.vue index 02db535f9..9b2e8bde0 100644 --- a/packages/component-library/src/components/navigation/mt-link/mt-link.vue +++ b/packages/component-library/src/components/navigation/mt-link/mt-link.vue @@ -1,88 +1,41 @@ -