Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: floats with only 0 as decimal places are converted to integer #120

Open
RafaelKr opened this issue Apr 4, 2022 · 0 comments
Open

Comments

@RafaelKr
Copy link

RafaelKr commented Apr 4, 2022

In the Shopware development template I want to explicitly use the docker image webdevops/php-apache-dev:8.0. For this I tried to use the following configuration:

const:
  DOCKER_IMAGE_PHP: webdevops/php-apache-dev
  DOCKER_IMAGE_PHP_VERSION: 8.0

If I do so, docker will try to pull webdevops/php-apache-dev:8 (note the missing .0) which is not available on dockerhub. I got a workaround by wrapping it in quotes which works fine on Linux:

const:
  DOCKER_IMAGE_PHP: webdevops/php-apache-dev
  DOCKER_IMAGE_PHP_VERSION: "8.0"

Today we tried to set it up on a MacBook of a colleague, although it's wrapped with quotes it will still convert it to an integer and therefore try to pull that non-existent image tag. We tried to escape them with the following options which all didn't work. They all were put into the docker-compose.override.yml literally:

\"8.0\"
8\.0
8.0 !!float

We also tried it with single quotes ('8.0') which led to the same result as double quotes.

For now we just use 8.1 on macOS which works fine. Is there a solution to this or is this something which has to be adjusted in the psh code?

@RafaelKr RafaelKr changed the title Bug: floats with only 0 decimal places are converted to integer Bug: floats with only 0 as decimal places are converted to integer Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant