-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAN Release 1.4.0 #29
Comments
@showteeth I see that you have released the package initially on CRAN, version 0.7.0, but it got removed again. Now with some additional work it should be possible to re-release it on CRAN. Are you up for this and, most importantly, responsive to the CRAN comments, emails etc that appear during the submission? |
…rk with basic solutions; closes showteeth#27, related to showteeth#29
@showteeth version 1.4.0 is now merged, can be submitted to CRAN soon. Please get back to me with your comments, otherwise I can also try to submit next week. |
@showteeth any thoughts on CRAN release? Your participation is required as you as the maintainer gets the emails from CRAN. |
@showteeth we can still get this back on CRAN. Is there any hope you will ever respond? You can say no of course. |
@showteeth package should still be submitted to CRAN; I can ask CRAN to transfer maintainership if you are unable to respond. |
@m-jahn OK! You are very familiar with this package. Sorry for the late response, I just finished my PhD! Next, we can maintain this package together. |
dear @showteeth, congratulations to your PhD! My apologies, I wasn't aware that you were occupied with that. Regarding the package, you can either submit it to CRAN yourself, or I can do that, but it is important that you are available under the given email adress . If I submit the package to CRAN, we need to transfer the |
OK! I will first try to submit it to CRAN by myself. |
Go for it. There's one additional open PR #41 that could be merged before submission. It will fix some of the open issues. |
I've already done it. Please check the email. |
Alright, I have confirmed the submission. |
the automatic pretest from CRAN found some problems which I think can be easily fixed. I will make some changes and open a PR, and then we can try to submit again. Will get back with more details. |
CRAN internal checks found:
Some of those are standard and usually nothing is done about them, particularly 1 and 5. The others should be fixed. |
@showteeth now that you have merged the latest PR you can resubmit the package. The confirmation email should be sent to your email address now because I changed the maintainer email. |
@m-jahn |
Thanks for trying! I think many people rely on CRAN and the safety and high standards it comes with. The regular checks including checks on the package's dependencies are something useful. Without that , upstream changes that make the package unusable can go unnoticed. I dont think that these issues are particularly difficult to fix, just need to find out what exactly the CRAN NOTEs mean. No need to give up already, now that we came so far |
one issue I was not aware is actually the thing with package See this answer: |
Let's list the main points here and try to address them:
I think this is doable. |
I added fixes for all of the problems and bumped the version to 1.4.1. You are free to resubmit |
Did you manage to re-submit and get feedback @showteeth ? |
CRAN checklist for re-release:
suggests
usethis::use_cran_comments()
Title:
andDescription:
@return
and@examples
Authors@R:
includes a copyright holder (role 'cph')Prepare for release:
urlchecker::url_check()
devtools::build_readme()
devtools::check(remote = TRUE, manual = TRUE)
devtools::check_win_devel()
Submit to CRAN:
usethis::use_version('patch')
devtools::submit_cran()
Wait for CRAN...
usethis::use_github_release()
usethis::use_dev_version(push = TRUE)
The text was updated successfully, but these errors were encountered: