Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.10: file_lock_test.go:43: Fatal call has possible formatting directive %s #9

Open
nim-nim opened this issue Mar 22, 2018 · 1 comment · May be fixed by #15
Open

Go 1.10: file_lock_test.go:43: Fatal call has possible formatting directive %s #9

nim-nim opened this issue Mar 22, 2018 · 1 comment · May be fixed by #15

Comments

@nim-nim
Copy link

nim-nim commented Mar 22, 2018 •
edited
Loading

cb568a3 does not pass unit tests with Go 1.10. At least:

Testing: "/builddir/build/BUILD/go-cb568a3e5cc06256f91a2da5a87455f717eb33f4/_build/src/github.com/siddontang/go/filelock"
+ GOPATH=/builddir/build/BUILD/go-cb568a3e5cc06256f91a2da5a87455f717eb33f4/_build:/usr/share/gocode
+ go test -buildmode pie -compiler gc -ldflags '-extldflags '\''-Wl,-z,relro  '\'''
# github.com/siddontang/go/filelock
./file_lock_test.go:43: Fatal call has possible formatting directive %s
FAIL    github.com/siddontang/go/filelock [build failed]
+ GOPATH=/builddir/build/BUILD/go-cb568a3e5cc06256f91a2da5a87455f717eb33f4/_build:/usr/share/gocode
+ go test -buildmode pie -compiler gc -ldflags '-extldflags '\''-Wl,-z,relro  '\'''
# github.com/siddontang/go/list2
./list_test.go:60: Errorf format %p has arg p of wrong type int
./list_test.go:73: Errorf format %p has arg n of wrong type int
FAIL    github.com/siddontang/go/list2 [build failed]
@siddontang
Copy link
Owner

can you send me a PR to fix it?

eclipseo added a commit to eclipseo/go that referenced this issue Jan 10, 2021
@eclipseo
Fix Errorf formatting
3ebea78 
Fix siddontang#9.

Signed-off-by: Robert-André Mauchin <[email protected]>
@eclipseo eclipseo linked a pull request Jan 10, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Errorf formatting eclipseo/go
2 participants
@siddontang @nim-nim