Skip to content
This repository has been archived by the owner on Aug 24, 2022. It is now read-only.

Extract committer from commit data #59

Open
clhunsen opened this issue Jun 22, 2017 · 3 comments
Open

Extract committer from commit data #59

clhunsen opened this issue Jun 22, 2017 · 3 comments

Comments

@clhunsen
Copy link
Contributor

Right now, only the commit date is stored in the commit table of the DB, but it would be also a good idea to get the committer, too (as a foreign key to the person table, of course).

Are there any obstacles to get the committer ID, too?

@wolfgangmauerer
Copy link
Collaborator

wolfgangmauerer commented Jun 22, 2017 via email

@clhunsen
Copy link
Contributor Author

I have not implemented anything yet. I would be glad if you implement this along with your changes. 😉

@clhunsen
Copy link
Contributor Author

clhunsen commented Dec 5, 2017

Any news on this, @wolfgangmauerer?

clhunsen added a commit to se-sic/codeface that referenced this issue Dec 15, 2017
For better traceability and to enable subsequent analyses, we now always
store the committer of a commit in the database during commit analysis
in addition to the commit's author.

To add the missing column in existing databases created with previous
schemas, run the following command inside MySQL:

ALTER TABLE `codeface`.`commit`
ADD COLUMN `committer`
    BIGINT NOT NULL COMMENT ''
    AFTER `author`,
ADD CONSTRAINT `commit_committer`
    FOREIGN KEY (`committer`)
    REFERENCES `codeface`.`person` (`id`)
    ON DELETE CASCADE
    ON UPDATE CASCADE,
DROP INDEX `commit_person_idx`,
ADD INDEX `commit_person_idx`
    (`author` ASC, `committer` ASC)  COMMENT '';

This fixes siemens#59.

Signed-off-by: Claus Hunsen <[email protected]>
clhunsen added a commit to se-sic/codeface that referenced this issue Jan 16, 2018
For better traceability and to enable subsequent analyses, we now always
store the committer of a commit in the database during commit analysis
in addition to the commit's author.

To add the missing column in existing databases created with previous
schemas, run the following command inside MySQL:

ALTER TABLE `codeface`.`commit`
ADD COLUMN `committer`
    BIGINT NOT NULL COMMENT ''
    AFTER `author`,
ADD CONSTRAINT `commit_committer`
    FOREIGN KEY (`committer`)
    REFERENCES `codeface`.`person` (`id`)
    ON DELETE CASCADE
    ON UPDATE CASCADE,
DROP INDEX `commit_person_idx`,
ADD INDEX `commit_person_idx`
    (`author` ASC, `committer` ASC)  COMMENT '';

This fixes siemens#59.

Signed-off-by: Claus Hunsen <[email protected]>
ecklbarb pushed a commit to ecklbarb/codeface that referenced this issue Feb 7, 2018
For better traceability and to enable subsequent analyses, we now always
store the committer of a commit in the database during commit analysis
in addition to the commit's author.

To add the missing column in existing databases created with previous
schemas, run the following command inside MySQL:

ALTER TABLE `codeface`.`commit`
ADD COLUMN `committer`
    BIGINT NOT NULL COMMENT ''
    AFTER `author`,
ADD CONSTRAINT `commit_committer`
    FOREIGN KEY (`committer`)
    REFERENCES `codeface`.`person` (`id`)
    ON DELETE CASCADE
    ON UPDATE CASCADE,
DROP INDEX `commit_person_idx`,
ADD INDEX `commit_person_idx`
    (`author` ASC, `committer` ASC)  COMMENT '';

This fixes siemens#59.

Signed-off-by: Claus Hunsen <[email protected]>
clhunsen added a commit to se-sic/codeface that referenced this issue Mar 22, 2018
For better traceability and to enable subsequent analyses, we now always
store the committer of a commit in the database during commit analysis
in addition to the commit's author.

To add the missing column in existing databases created with previous
schemas, run the following command inside MySQL:

ALTER TABLE `codeface`.`commit`
ADD COLUMN `committer`
    BIGINT NOT NULL COMMENT ''
    AFTER `author`,
ADD CONSTRAINT `commit_committer`
    FOREIGN KEY (`committer`)
    REFERENCES `codeface`.`person` (`id`)
    ON DELETE CASCADE
    ON UPDATE CASCADE,
DROP INDEX `commit_person_idx`,
ADD INDEX `commit_person_idx`
    (`author` ASC, `committer` ASC)  COMMENT '';

This fixes siemens#59.

Signed-off-by: Claus Hunsen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants