rsc: Cleanup TODOs (#1577)

* rsc: Cleanup TODOs * TODOs are TODONES
sifive · May 30, 2024 · c7fd4cd · c7fd4cd
1 parent 40fc5c0
commit c7fd4cd
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/share/wake/lib/system/remote_cache_api.wake b/share/wake/lib/system/remote_cache_api.wake
@@ -420,7 +420,6 @@ export def rscApiGetStringBlob ((CacheSearchBlob _ uri): CacheSearchBlob): Resul
         else failWithError "rsc: Failed to parse bytes strings into bytes from db path: '{path}'"
 
         bytes
-        # TODO: this only supports ASCII, not unicode. This needs to be enforced somewhere.
         | map integerToByte
         | cat
         | Pass
@@ -451,10 +450,6 @@ export def rscApiGetStringBlob ((CacheSearchBlob _ uri): CacheSearchBlob): Resul
 #  rscApiGetFileBlob (RemoteCacheBlob "asdf" "https://...") "foo/bar" 0644 = Pass "foo/bar" 
 # ```
 export def rscApiGetFileBlob ((CacheSearchBlob _ uri): CacheSearchBlob) (path: String) (mode: Integer): Result String Error =
-    # TODO: use "small blob" for this and also parse the schema out
-    # require False = id ==* "00000000-0000-0000-0000-000000000000"
-    # else Pass  ""
-
     require Pass downloadPath =
         buildHttpRequest uri
         | setMethod HttpMethodGet
@@ -500,8 +495,7 @@ export def rscApiGetFileBlob ((CacheSearchBlob _ uri): CacheSearchBlob) (path: S
 def strToBytes (str: String): List Integer =
     str
     | explode
-    # FIXME: unicodeToInteger may return values larger than u8 which will break the serialization
-    | map (unicodeToInteger _)
+    | map (byteToInteger _)
 
 # listFlattenWithNull ((1,2,3,), (4,5,6,), (7,8,9,),) = (1,2,3,0,4,5,6,0,7,8,9,0,)
 def listFlattenWithNull (parts: List (List Integer)): List Integer =

diff --git a/share/wake/lib/system/remote_cache_runner.wake b/share/wake/lib/system/remote_cache_runner.wake
@@ -356,7 +356,6 @@ def postJob (rscApi: RemoteCacheApi) (job: Job) (_wakeroot: String) (hidden: Str
         CachePostRequestOutputFile path (mode | mode2bits) id
         | Pass
 
-    # TODO: readlink may need to be a PRIM for performance reasons
     # The path output by the job itself is the created symlink. The contents of the symlink
     # is the original file on disk. This is reversed when downloading a job.
     def makeSymlink (Pair link _) =