db: Add option to capture canceled jobs #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to run a test to verify that wakebox timed out jobs show up as canceled then I can land this |
| rm -f wake.db | ||
|
|
||
| # Use || true to ignore the expected non-0 return from timeout | ||
| timeout 1 ${WAKE} test || true |
There was a problem hiding this comment.
We don't need test Unit here?
There was a problem hiding this comment.
Nope. test is exported as a CLI function so it expects a List String and with nothing is specified then Nil is passed
Comment on lines
+437
to
+440
| bool is_db_inspection = | ||
| !clo.job_ids.empty() || !clo.output_files.empty() || !clo.input_files.empty() || | ||
| !clo.labels.empty() || !clo.tags.empty() || clo.last_use || clo.last_exe || clo.failed || | ||
| clo.tagdag || clo.timeline || clo.taguri || clo.simple || clo.simple_timeline || clo.canceled; |
There was a problem hiding this comment.
Do we have a linter for C++?
There was a problem hiding this comment.
Yep, just for formatting though. clang-format (version 12.0.X)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--canceledwhich captures jobs that were canceled in the last build (usually by ctrl+c). This works similarly to--failedin that it will forget the list of canceled jobs after the next wake invocation.