rsc: Add updated_at to blob #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -492,6 +492,7 @@ mod tests { | |||
| let active_key = entity::blob::ActiveModel { | |||
| id: NotSet, | |||
| created_at: Set((Utc::now() - Duration::days(5)).naive_utc()), | |||
| updated_at: Set((Utc::now() - Duration::days(5)).naive_utc()), | |||
There was a problem hiding this comment.
I think you also need to update the ttl_eviction test later in this file, since it is only setting created_at right now. I'm a little surprised that test still passed so maybe I'm missing something or we might not be running the tests I think we are.
There was a problem hiding this comment.
We might not be running the tests I think we are.
This one :) The TTL eviction test is for job eviction. Blob eviction is a separate system with no eviction "policy". For blobs we just delete any unreferenced blob where updated_at older than X. The only way for a blob to become unreferenced is for a job pointing at it to be evicted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
update_atcolumn to Blob to track when updated. Blob eviction TTL now uses updated_at instead of created_at