Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsc: Correct structure to match cargo expectations #1571

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

V-FEXrt
Copy link
Contributor

@V-FEXrt V-FEXrt commented May 20, 2024

Previously the rsc package had a "weird" folder structure from the perspective of cargo. This caused over 20 incorrect not used warnings which then went on to hide ~10 real not used warnings.

In order to maintain project health its important that incorrect warnings don't hide the real ones.

Therefore, the files have been moved around to match the expected layout of a multi-binary package as described https://doc.rust-lang.org/cargo/guide/project-layout.html which fixed all the incorrect not used warnings.

@V-FEXrt V-FEXrt requested review from colinschmidt and ag-eitilt May 20, 2024 18:03
@V-FEXrt V-FEXrt force-pushed the rsc-fix-structure branch from 918ae76 to 1a1f7d8 Compare May 20, 2024 18:42
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@V-FEXrt V-FEXrt merged commit c518060 into master May 24, 2024
12 checks passed
@V-FEXrt V-FEXrt deleted the rsc-fix-structure branch May 24, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants