Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsc: Move client code to dedicated package #1585

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

V-FEXrt
Copy link
Contributor

@V-FEXrt V-FEXrt commented Jun 7, 2024

Moves all of the RSC client code into the remote_cache package for better isolation and deals with the associated fallout

Copy link
Collaborator

@ag-eitilt ag-eitilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm completely in favour of the ongoing de-monolithization of package wake.

@@ -561,10 +570,10 @@ def asBytesDelimedByNull (parts: List String): List Integer =
| listFlattenWithNull

# getPathAsJson (Path "foo" "asdf") = (JObject ...)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed and absolutely not important, but hashes can't contain s. 😉

Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@V-FEXrt V-FEXrt merged commit 3687b61 into master Jul 1, 2024
12 checks passed
@V-FEXrt V-FEXrt deleted the rsc-make-package branch July 1, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants