Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsc: Split configs for rsc/rsc_tool #1606

Merged
merged 4 commits into from
Jul 29, 2024
Merged

rsc: Split configs for rsc/rsc_tool #1606

merged 4 commits into from
Jul 29, 2024

Conversation

V-FEXrt
Copy link
Contributor

@V-FEXrt V-FEXrt commented Jul 25, 2024

This is a simplification and split of the RSC config files in preparation for a larger push for config changes.

Unneeded configs and arg flags were removed and the rsc and rsc_tool were given dedicated config types

Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -502,6 +430,36 @@ mod tests {
Ok(inserted_key.id)
}

async fn create_insecure_api_key(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming these are just moves from above.

@V-FEXrt V-FEXrt merged commit 1ef6d21 into master Jul 29, 2024
11 checks passed
@V-FEXrt V-FEXrt deleted the rsc-config-cleanup branch July 29, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants