updateToSchemaVersion1100 test is flaky

[brjsp]

Using a supported version?

• I have searched searched open and closed issues for duplicates.
• I am building Signal from source

Optimize markAllCallHistoryReadInConversation occasionally fails with this error message:

  1) SQL/updateToSchemaVersion1100
       Optimize markAllCallHistoryReadInConversation
         is fast:

      AssertionError: expected 59.411166000001685 to be below 50
      + expected - actual

      -59.411166000001685
      +50
      
      at Context.<anonymous> (ts/test-node/sql/migration_1100_test.js:1:2204)
      at process.processImmediate (node:internal/timers:483:21)

Signal version

7.25.0 and a few previous ones

Operating system

Linux (various openSUSE/Fedora)

[mosbat]

I had this error message but after installing the nodeJS version stated in the documentation, it was gone. You can find info here: https://github.com/signalapp/Signal-Desktop/blob/main/.nvmrc

Let me know if this fixed the problem.

[brjsp]

@mosbat the advice is nonsense — the tests are run under Electron, not Node, so the Node version is irrelevant.

anyway we'll probably just patch out that test since it seems to measure some timing and our build machines are rather slow.

[mosbat]

@brjsp context matters but you didn't mention anything about Electron