Consistency ?

[ghost]

libsignal-protocol-c/src/signal_protocol.h

Line 503 in 4a137ea

int (*load_pre_key)(signal_buffer **record, uint32_t pre_key_id, void *user_data);

Almost every field name end with _func, but not here.

[dkonigsberg]

While I agree that there should be more consistency with callback naming conventions, its not immediately obvious which way to go. A few of the callbacks to use the _func suffix, but many do not. So its not a case of making one small change, but rather a case for making a rather large number of small changes. (Note that pull request #116 changes a lot of callback names.)

If someone can point me to a good example of a C style-guide/convention for this, I'll take a change into consideration.

Also, it should be kept in mind that a change like this will break all existing code that uses the library. Therefore, I shouldn't forget to make a larger version number bump when releasing any code that includes such a change.