Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfiles use amd64-specific images #1575

Open
dmitris opened this issue Feb 22, 2024 · 1 comment
Open

Dockerfiles use amd64-specific images #1575

dmitris opened this issue Feb 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@dmitris
Copy link

dmitris commented Feb 22, 2024

Description
Currently trying to run docker-compose up -d fails on an M1 (arm64) Mac because the golang images "pinned" in the Dockerfiles are amd64-specific, which makes the development on newer Macs difficult. In particular, it leads to failing e2d tests in sigstore/cosign (https://github.com/sigstore/cosign/blob/main/test/e2e_test.sh). How important is it to "pin" the golang builder images to a specific sha256 (which is also architecture specific)? For the golang image, a simple fix for me is to change the image golang:1.21.6@sha256:7b575fe0d9c2e01553b04d9de8ffea6d35ca3ab3380d2a8db2acc8f0f1519a53 to just golang:1.21.6 (or golang:1.22.0), since the golang is multiarch [1] . Would this be acceptable or do you have any concerns?

There is also an issue with the gcr.io/trillian-opensource-ci/ctfe docker image which I believe is not multiarch and would have to be rebuilt as multiarch:

$ docker run -t -i --name tr gcr.io/trillian-opensource-ci/ctfe /bin/bash
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
F0222 16:32:34.005450       1 main.go:115] Failed to read config: open : no such file or directory
prebid-server$ cd ~/gh/sigstore/fulcio/

Slack discussion: https://sigstore.slack.com/archives/C01PZKDL4DP/p1708615569583539

[1] https://hub.docker.com/_/golang -> Quick reference (cont.) -> Supported architectures

@dmitris dmitris added the enhancement New feature or request label Feb 22, 2024
@haydentherapper
Copy link
Contributor

Can we select an image based on the architecture docker-compose is run on? Pinning is a good practice as tags are mutable.

cc @cpanato

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants