Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Return a list of signature paths as an output #149

Open
webknjaz opened this issue Jul 16, 2024 · 1 comment
Open

[FR] Return a list of signature paths as an output #149

webknjaz opened this issue Jul 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@webknjaz
Copy link

Usually, when people want to refer to specific signatures for manual upload, they tend to use wildcards. However, the file extensions have already changed twice, and it's not really future-proof to keep doing that and remember to change them whenever the action updates. This is especially problematic with auto-merges, since they typically can't catch the mismatch, as this action would only run on release. And it's quite unpleasant to face with having to fix things this late in the process.

Providing a way to grab that list (LF-separated would be best I think) and feed it to another action input seems like a good solution to the problem.

@webknjaz webknjaz added the enhancement New feature or request label Jul 16, 2024
@woodruffw
Copy link
Member

Makes sense. Users can currently access this list via the GHA_SIGSTORE_PYTHON_INTERNAL_SIGNING_ARTIFACTS environment variable that we inject after signing completes, although that list also includes each input next to its signed bundle.

Adding a separate explicitly stable output for just the bundle paths should be straightforward 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants