From 5f474cca9e214d8088235d534e2bd65f5b153118 Mon Sep 17 00:00:00 2001 From: Jussi Kukkonen Date: Tue, 9 Jul 2024 09:58:30 +0300 Subject: [PATCH 1/3] Workflows: remove default input arg from action call Signed-off-by: Jussi Kukkonen --- .github/workflows/release.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 70297e2..eeed331 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -23,4 +23,3 @@ jobs: id: sigstore-python with: inputs: action.yml action.py - release-signing-artifacts: true From d2f6ba070b4af67dfd7a37e682be7a190a7fbafc Mon Sep 17 00:00:00 2001 From: Jussi Kukkonen Date: Tue, 9 Jul 2024 10:00:54 +0300 Subject: [PATCH 2/3] workflows: Remove unnecessary selftest release-signing-artifacts defaults to "true" so the removed test now duplicates the previous test. We could try testing the release-signing-artifacts == "false" but that's a bit trickier since it could only be done in a release event... Signed-off-by: Jussi Kukkonen --- .github/workflows/selftest.yml | 29 ----------------------------- 1 file changed, 29 deletions(-) diff --git a/.github/workflows/selftest.yml b/.github/workflows/selftest.yml index f2edc93..403ddd1 100644 --- a/.github/workflows/selftest.yml +++ b/.github/workflows/selftest.yml @@ -93,35 +93,6 @@ jobs: [[ -f ./test/white\ space.txt ]] || exit 1 [[ -f ./test/more\ white\ space.txt ]] || exit 1 - selftest-release-signing-artifacts-no-op: - strategy: - matrix: - os: - - ubuntu-latest - - macos-latest - - windows-latest - runs-on: ${{ matrix.os }} - if: (github.event_name != 'pull_request') || !github.event.pull_request.head.repo.fork - steps: - - uses: actions/checkout@v4 - - uses: actions/setup-python@v5 - if: ${{ matrix.os != 'ubuntu-latest' }} - with: - python-version: "3.x" - - name: Sign artifact and publish signature - uses: ./ - id: sigstore-python - with: - inputs: ./test/artifact.txt - # The trigger for this test is not a release, so this has no effect - # (but does not break the workflow either). - release-signing-artifacts: true - internal-be-careful-debug: true - - name: Check outputs - shell: bash - run: | - [[ -f ./test/artifact.txt.sigstore.json ]] || exit 1 - selftest-xfail-invalid-inputs: runs-on: ubuntu-latest strategy: From 054779146cab768ffb5f6a7ffa19a8644e16b9a2 Mon Sep 17 00:00:00 2001 From: Jussi Kukkonen Date: Tue, 9 Jul 2024 18:04:38 +0300 Subject: [PATCH 3/3] workflows: Drop recently removed job from needs-list Signed-off-by: Jussi Kukkonen --- .github/workflows/selftest.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/selftest.yml b/.github/workflows/selftest.yml index 403ddd1..c1b52f7 100644 --- a/.github/workflows/selftest.yml +++ b/.github/workflows/selftest.yml @@ -341,7 +341,6 @@ jobs: needs: - selftest - selftest-whitespace - - selftest-release-signing-artifacts-no-op - selftest-xfail-invalid-inputs - selftest-staging - selftest-glob