Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking scripts #206

Closed
laurentsimon opened this issue Jun 12, 2024 · 4 comments · Fixed by #306
Closed

Benchmarking scripts #206

laurentsimon opened this issue Jun 12, 2024 · 4 comments · Fixed by #306
Labels
enhancement New feature or request
Milestone

Comments

@laurentsimon
Copy link
Collaborator

laurentsimon commented Jun 12, 2024

We'd like to have benchmarking scripts to improve on the current shell https://github.com/sigstore/model-transparency/blob/main/model_signing/benchmarks/run.sh

We welcome contributions; this is a really important piece to be able to compare various signing options (serialization, hash + params) and be able to cut a v1 release.

@mihaimaruseac has written some python-based script we can work off.

@font FYI

@laurentsimon laurentsimon added the enhancement New feature or request label Jun 12, 2024
@laurentsimon laurentsimon changed the title Benchmarking scrips Benchmarking scripts Jun 12, 2024
@mihaimaruseac mihaimaruseac added this to the V1 release milestone Jun 12, 2024
@font
Copy link
Member

font commented Jun 12, 2024

@mihaimaruseac has written some python-based script we can work off.

@mihaimaruseac Are you able to share these?

@mihaimaruseac
Copy link
Collaborator

I'm debating between sharing the scripts as I used them for previous benchmarks or adapting them to the new API (under work) and having them then act as CI checks

@laurentsimon
Copy link
Collaborator Author

+1 on adapting them to the new APIs. Sharing the script may speed up adapting them to the new API, if someone's interested in doing the work

@spencerschrock
Copy link
Contributor

We should make sure to benchmark Python 3.10 vs Python 3.11 / 3.12. I'm curious if the hashlib.file_digest polyfill (#300) will show a meaningful difference, as there were 1-2 optimizations in the upstream that weren't included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants