Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve program sensor #53

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

frimtec
Copy link
Contributor

@frimtec frimtec commented Dec 8, 2024

Currently the sensor "program" shows a combination of two device states (Inactive and Program).
This leads to the following issues:

  • For devices like the "Cooler V2000", the device value of program is mostly hidden with "standby" as the value "Inactive" is true in normal operation mode.
  • For devices like the "Combair-Steamer V2000", the program shows "standby" even if the device is active (Inactive is false), but no specific program is selected.

The PR tries to address both issues:

  • If the value of the device field "Program" is set, it has always priority.
  • If the value of the device field "Program" is empty, depending on the device field "Inactive" the value "standby" or "active" is reported.

Do not hide program value from device if inactive is true
Copy link
Owner

@siku2 siku2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@siku2 siku2 merged commit bc995bc into siku2:main Dec 10, 2024
4 checks passed
@frimtec frimtec deleted the feature/improve-program-sensor branch February 24, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants